[p2pu-dev] plugins.js and document.write()
Dirk Uys
dirk at p2pu.org
Tue Aug 7 08:23:28 UTC 2012
Hi everyone, Paul, Zuzel
After some focused debugging on why conversion tracking isn't working (Iow,
after I verified a 100 times that the code is correct and accepted that it
still doesn't work) I found the problem or at least what I think is the
problem:
It seems like in plugins.js (
https://github.com/p2pu/lernanta/blob/master/lernanta/static/js/plugins.js#L47)
essentially disables document.write(). Except if you want to write
"docwriteregexwhitelist". It looks like this comes from HTML 5 Boilerplate?
What was the reasoning behind this - is this to stop other JavaScript from
doing bad things? Doesn't embed.ly already do this? Or do we allow script
tags in the rich text editor?
I would like to get conversion tracking to work on the site, so can I
safely remove this bit of code?
Cheers
Dirk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.p2pu.org/pipermail/p2pu-dev/attachments/20120807/969509cf/attachment.html>
More information about the p2pu-dev
mailing list